Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial commit of editions and octane landing pages #228

Merged
merged 18 commits into from Mar 18, 2019
Merged

initial commit of editions and octane landing pages #228

merged 18 commits into from Mar 18, 2019

Conversation

MelSumner
Copy link
Member

@MelSumner MelSumner commented Mar 14, 2019 •
edited

first commit to add editions and editions/octane pages to website. Resolves #229

@MelSumner MelSumner added the Octane Upgrade ember-website app to Ember Octane label Mar 14, 2019
@MelSumner MelSumner requested a review from mansona March 14, 2019 17:19
mansona
mansona previously approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this PR has the text "an introductory paragraph" 😂 but I think that we could actually merge it right now so we have the url to point to from the Guides warning 👍

mansona
mansona previously approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again I think this is more than ready to get merged 👍 I would like to see it deployed and then we can iterate from there

acorncom
acorncom previously approved these changes Mar 15, 2019
View reviewed changes
app/templates/editions/octane.hbs Outdated Show resolved Hide resolved
@jenweber
Copy link
Contributor

@MelSumner can we go ahead and ship it? Thanks for your work!

@MelSumner MelSumner dismissed stale reviews from acorncom and mansona via 032df12 March 17, 2019 22:39
@MelSumner MelSumner marked this pull request as ready for review March 17, 2019 22:40
@jenweber jenweber mentioned this pull request Mar 17, 2019
Merged
@jenweber
Copy link
Contributor

Once this is merged, please merge ember-learn/guides-source#641 since it updates the URL used in the Octane Guides banner.

@jenweber jenweber merged commit bae6ebf into master Mar 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/octane-landing-page branch March 18, 2019 01:37
@jenweber
Copy link
Contributor

Merged! Thanks Mel for your work and others for the reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josemarluedke josemarluedke josemarluedke left review comments

@jenweber jenweber jenweber approved these changes

@mansona mansona mansona left review comments

@acorncom acorncom acorncom left review comments

@tomdale tomdale Awaiting requested review from tomdale

Assignees
No one assigned
Labels
Octane Upgrade ember-website app to Ember Octane
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@MelSumner @jenweber @tomdale @josemarluedke @mansona @acorncom