Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlay sidebar implementation for mobile and side-by-side for desktop #38

Merged
merged 14 commits into from
May 14, 2020

Conversation

nickschot
Copy link
Contributor

@nickschot nickschot commented May 8, 2020

Fixes #23

MVP of the new overlay "sidebar" on mobile, along with the side-by-side implementation for desktop

Edit: TODO items moved to #43

nickschot and others added 13 commits May 14, 2020 14:19
Co-Authored-By: Nick Schot <nickschot@users.noreply.github.com>
Co-Authored-By: Nick Schot <nickschot@users.noreply.github.com>
Co-Authored-By: Nick Schot <nickschot@users.noreply.github.com>
Co-Authored-By: Nick Schot <nickschot@users.noreply.github.com>
Co-Authored-By: Nick Schot <nickschot@users.noreply.github.com>
Co-Authored-By: Nick Schot <nickschot@users.noreply.github.com>
Co-Authored-By: Nick Schot <nickschot@users.noreply.github.com>
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍 any of the work that still needs to be done can be applied after this is merged

@mansona mansona changed the title [WIP] overlay sidebar implementation overlay sidebar implementation for mobile and side-by-side for desktop May 14, 2020
@mansona mansona merged commit 7ce6079 into ember-learn:master May 14, 2020
@nickschot nickschot deleted the overlay-sidebar branch May 21, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design the approach for the sidebar in the new blog
2 participants