Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octane guides review: back out of MU project layout for file paths #584

Closed
mike-north opened this issue Mar 12, 2019 · 2 comments
Closed
Labels

Comments

@mike-north
Copy link
Contributor

In light of Module Unification project layout being de-scoped from the octane edition, we need the updates to the guides (#455) to be converted back to "classic" project layout (/app and /addon folders).

These paths are mostly found in markdown "fenced code blocks"

```hbs {data-filename=src/ui/routes/application/template.hbs}

```

In this case, we'd convert the file path as follows

A top-level template

-src/ui/routes/application/template.hbs
+app/templates/application.hbs

Other examples

A component's JS module

-src/ui/components/hello/component.js
+app/components/hello.js

A component's HBS module

-src/ui/components/hello/template.hbs
+app/templates/components/hello.hbs

A controller

-src/ui/routes/application/controller.js
+app/controllers/application.js
@ghost
Copy link

ghost commented Mar 15, 2019

@betocantu has started addressing this in #612. Linking for future contributors.

@dennismende
Copy link
Contributor

dennismende commented Mar 17, 2019

With #636 all occurrences of MU project structure file paths should have been changed back to current structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants