New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work for 3.10 or 3.11 - update code blocks to reflect new import paths for ember-data packages #740
Comments
jenweber
changed the title
Work for 3.10 - update code blocks to reflect new import paths for ember-data packages
Work for 3.10 or 3.11 - update code blocks to reflect new import paths for ember-data packages
Apr 11, 2019
14 tasks
5 tasks
It doesn't look like anyone picked this one up. I'll work on this |
Thank you, that would be awesome!!! |
#814 will take care of the imports. Links will be harder to figure out. I messaged the data team to see if they have tried to build the API docs yet using the new packages layout. |
@jenweber did this happen, and if not, should it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Ember Data has restructured their repo so that it has packages, similar to how in Ember we do
import { inject as service} from '@ember/service'
instead ofimport Ember from 'ember'
. This feature will probably land in 3.10 or 3.11, so we should get ready for these changes.A PR should branch from
master
and targetmaster
, and will be merged once that version of Ember Data is released.To-do:
import DS from 'ember-data'
is used in the guides, and fix them to reflect the new package structure. You can figure out the new imports by looking at themaster
branch of ember-data. Guides-source have ~60 results.https://api.emberjs.com/ember-data/release/modules/ember-data
. Update them as best you can. Note that the links checkers tests will fail until that version of Ember Data is released and available in the API docs. So just ignore those link check tests while you are working, but keep an eye out for other test failuresPart of emberjs/rfc-tracking#11
The text was updated successfully, but these errors were encountered: