Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use service named import instead of inject #1766

Merged
merged 1 commit into from
Jan 9, 2022
Merged

Use service named import instead of inject #1766

merged 1 commit into from
Jan 9, 2022

Conversation

locks
Copy link
Contributor

@locks locks commented Jan 9, 2022

Updated to be inline with RFC 752.

@locks locks requested a review from a team January 9, 2022 14:52
jaredgalanis
jaredgalanis approved these changes Jan 9, 2022
View reviewed changes
Copy link
Member

@jaredgalanis jaredgalanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like there's one CI issue, otherwise seems good. 👍

@locks
Copy link
Contributor Author

locks commented Jan 9, 2022

Ah shoot, I updated pages that belong to the tutorial.

@locks locks merged commit 3a8230b into master Jan 9, 2022
@locks locks deleted the service-inject-import branch January 9, 2022 23:07
@locks locks mentioned this pull request Jan 9, 2022
Closed
@IgnaceMaes IgnaceMaes mentioned this pull request Feb 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredgalanis jaredgalanis jaredgalanis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@locks @jaredgalanis