Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OCTANE] Working with JavaScript #454

Merged
merged 2 commits into from
Feb 15, 2019
Merged

[OCTANE] Working with JavaScript #454

merged 2 commits into from
Feb 15, 2019

Conversation

pzuraq
Copy link
Contributor

@pzuraq pzuraq commented Feb 14, 2019

Closes #429

This PR adds the Working with JavaScript section to the Octane guides. It gives users a brief introduction to JS in Ember, setting up expectations and linking them to external resources such as the MDN guides and javascript.info if they do not know it very well yet. It also includes breakdowns of Native and Classic classes. In particular, native classes need to be covered in more detail than your average guide since we rely on decorators and fields, which are not generally covered in other guides yet.

TODO:

  • Expand decorators section slightly
  • Update classic class section to mirror native class section
  • Add cheat sheet

@MelSumner MelSumner added this to In progress in Octane Edition Guides via automation Feb 14, 2019
@tomdale
Copy link
Contributor

tomdale commented Feb 15, 2019

This looks great. I’m getting excited!

Chris Garrett added 2 commits February 14, 2019 18:36
Adds the Working with JavaScript section to the guides, and removes the
equivalent sections from the existing guides.
@pzuraq pzuraq changed the title [WIP][OCTANE] Working with JavaScript [OCTANE] Working with JavaScript Feb 15, 2019
@pzuraq
Copy link
Contributor Author

pzuraq commented Feb 15, 2019

Updated, this is ready to review! 😄

@MelSumner MelSumner self-requested a review February 15, 2019 15:21
Copy link
Member

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to get it in the branch, we can iterate from here.

@MelSumner MelSumner merged commit 45f2322 into octane Feb 15, 2019
Octane Edition Guides automation moved this from In progress to Done Feb 15, 2019
@pzuraq pzuraq deleted the working-with-javascript branch February 15, 2019 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants