Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to prevent default as per #569

Merged
merged 6 commits into from
Mar 13, 2019
Merged

Changes to prevent default as per #569

merged 6 commits into from
Mar 13, 2019

Conversation

sonic1981
Copy link
Contributor

@MelSumner MelSumner requested a review from a team March 10, 2019 17:01
@acorncom
Copy link
Member

@sonic1981 those improvements look great. Tests were failing here, so I've merged master in again, but will merge if things go green here

@acorncom acorncom merged commit ae336a7 into ember-learn:master Mar 13, 2019
@sonic1981
Copy link
Contributor Author

Thanks @acorncom

jenweber pushed a commit that referenced this pull request Mar 16, 2019
This is in relation to issue emberjs/website#3850
previously merged using pull request #569
cspanring pushed a commit to cspanring/guides-source that referenced this pull request Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants