Add guidelines for nested TOC #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbieTheWagner
approved these changes
Oct 10, 2019
kennethlarsen
approved these changes
Oct 11, 2019
locks
approved these changes
Oct 11, 2019
|
Thanks everyone for the feedback! I will share progress updates on the Discord channel for the learning team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, in the Ember Table of Contents, there can be just one topic grouping, which has an index page and subpages. This PR adds guidelines for adding one more level of nesting.
The original gist can be found here: https://gist.github.com/jenweber/2db1fdaa39f31f45490f9126fcfa8215
Here's an example from the ancient guides Cookbook: