Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for --lang flag #173

Closed
MelSumner opened this issue Aug 24, 2020 · 5 comments · Fixed by #174
Closed

add support for --lang flag #173

MelSumner opened this issue Aug 24, 2020 · 5 comments · Fixed by #174

Comments

@MelSumner
Copy link
Member

ensure that super-rentals supports the new --lang flag in ember-cli.
@rwjblue
Copy link
Contributor

rwjblue commented Aug 24, 2020

It will either land in ember-cli@3.21.0 or ember-cli@3.22.0 (depending on how I branch).

@rwjblue
Copy link
Contributor

rwjblue commented Aug 24, 2020

Landed in ember-cli@3.21.0-beta.2

@ijlee2
Copy link
Member

ijlee2 commented Jan 13, 2021

Hi, @fozy81. Let me move this issue to super-rentals-tutorial repo. To suggest changes to the Super Rentals tutorial, you will want to clone that repo and open your pull request there. (Thank you for helping! 🌟)

@ijlee2 ijlee2 transferred this issue from ember-learn/super-rentals Jan 13, 2021
@fozy81
Copy link
Member

fozy81 commented Jan 13, 2021

Thanks @ijlee2 , will PR soon.

@fozy81
Copy link
Member

fozy81 commented Jan 13, 2021

Hi @ijlee2 I've prepared a PR. I think it's okay and passes tests but please review. However...I wasn't sure how to view it / build the super-rentals-tutorials locally to view it (?).

@ijlee2 ijlee2 mentioned this issue Jan 13, 2021
Merged
ijlee2 added a commit that referenced this issue Mar 20, 2021
@fozy81 @ijlee2
add --lang option to tutorial fixes issue #173 (#174)
5e6610d 
* add --lang option to tutorial fixes issue #173

* Update src/markdown/tutorial/part-1/01-orientation.md

Co-authored-by: Isaac Lee <16869656+ijlee2@users.noreply.github.com>

* fix typo issue #173

Co-authored-by: Isaac Lee <16869656+ijlee2@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add --lang option to tutorial fixes issue #173
4 participants
@rwjblue @fozy81 @MelSumner @ijlee2