Ember 4 Upgrade #1174
Merged
Ember 4 Upgrade #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* eslint 8 * Swap node lint plugin for replacement * Fix assert.equal lint failures * Run prettier * Remove destroyable polyfill (inert after 3.22) * Drop Ember 3.24 support * Add Ember 4.x test scenarios * Add missing routes for new docs (added in previous PRs) * Bump various ember-related deps to latest * Remove 2 archived/unneeded ember deps * Add required @ember/string dep * Drop support for Node 10/12/14 * Bump release-it deps to latest
|
Embroider test failures are due to needing to add ember-data as a devDep of the test app because ember-cli-addon-docs requires it as a peerDep, and recent changes cause the demo app to break without it: It's highly likely that code in the addon package is still embroider-compatible (since it hasn't changed at all), but because the demo app and test app are tightly coupled, we cannot have a passing test run. We should be ok to merge this for now, and the long-term fix would be to split the entire demo app into its own package within the workspace, such that the test app no longer needs dependencies related to ember-cli-addon-docs. |
|
To account for this, I've marked the embroider builds as "experimental" in the GHA config for now. |
* Also remove deploy setup * Restore embroider scenarios as stable
scalvert
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates for v7 to support Ember@4
Internal: