Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ember-try for 4.x #1709

Merged
merged 1 commit into from Jan 27, 2023
Merged

Update ember-try for 4.x #1709

merged 1 commit into from Jan 27, 2023

Conversation

hjdivad
Copy link
Collaborator

@hjdivad hjdivad commented Jan 27, 2023 •
edited

@github-actions
Copy link

github-actions bot commented Jan 27, 2023 •
edited

Performance Report for e71da07

Scenario - materializing-lots: ☑️ Performance is stable

☑️ duration
phase no difference [-15ms to 12ms]
☑️ Phase [navigationStart] => [start-loading]
phase no difference [-3ms to 4ms]
☑️ Phase [start-loading] => [pushed-payload]
phase no difference [-10ms to 6ms]
☑️ Phase [pushed-payload] => [end-loading]
phase no difference [-6ms to 4ms]
☑️ Phase [end-loading] => [Test End]
phase no difference [0ms to 0ms]

Scenario - materializing-small: ☑️ Performance is stable

☑️ duration
phase no difference [-5ms to 2ms]
☑️ Phase [navigationStart] => [start-loading]
phase no difference [-4ms to 2ms]
☑️ Phase [start-loading] => [pushed-payload]
phase no difference [-1ms to 0ms]
☑️ Phase [pushed-payload] => [end-loading]
phase no difference [0ms to 1ms]
☑️ Phase [end-loading] => [Test End]
phase no difference [0ms to 0ms]

Scenario - rendering: ☑️ Performance is stable

☑️ duration
phase no difference [-3ms to 12ms]
☑️ Phase [navigationStart] => [start-loading]
phase no difference [-1ms to 5ms]
☑️ Phase [start-loading] => [pushed-payload]
phase no difference [0ms to 0ms]
☑️ Phase [pushed-payload] => [end-loading]
phase no difference [0ms to 0ms]
☑️ Phase [end-loading] => [Test End]
phase no difference [-4ms to 2ms]

@hjdivad hjdivad force-pushed the hjblue/update-to-ember-4 branch 2 times, most recently from be490bc to edf008a Compare January 27, 2023 23:06
@hjdivad hjdivad marked this pull request as ready for review January 27, 2023 23:07
@hjdivad hjdivad requested a review from rwjblue January 27, 2023 23:19
@hjdivad hjdivad merged commit 0c92f71 into master Jan 27, 2023
@hjdivad hjdivad deleted the hjblue/update-to-ember-4 branch January 27, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue Awaiting requested review from rwjblue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@hjdivad