Deprecate modifier() without { eager: false }

[chriskrycho]

This assumes, and should land immediately after, #222.

[rwjblue]

Overall, LGTM. One minor inline comment, and I think it needs a rebase/merge/etc to drop out the commits from #222.

[beerinho]

Hey @chriskrycho, what is the plan to update the docs with the changes in this PR? I updated ember-modifier yesterday to 3.2.0 and am getting the deprecation about not passing options, I feel like I have updated my modifier to pass in {eager: false} but I still get the deprecation warning and I couldn't find anything in the docs to help me figure out where I'm going wrong. My modifier looks like this:

  return modifier(
    function suggestModifier(element, [function_, ...args], named) {
        ...function code
    },
    { eager: false }
  );

[chriskrycho]

The docs are updated! Additionally there is an entire migration guide. That said, I’m sorry you’re having this issue; please open an issue with a more detailed report so we can help you get to the bottom of it (and possibly fix the deprecation if it’s firing when it shouldn’t be).

[chriskrycho]

I believe this is probably #249. I'll have a fix out for it in a while.