Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom tag name #112

Closed
estshy opened this issue Sep 28, 2016 · 3 comments
Closed

Custom tag name #112

estshy opened this issue Sep 28, 2016 · 3 comments
Labels
bug

Comments

@estshy
Copy link

estshy commented Sep 28, 2016 •
edited

This package breaks when there is a a custom html tag with a dash inside and it should not as Ember angle bracket components will be introduced soon.

<foo-bar>
</foo-bar>

Cannot read property 'tag' of undefined
@rwjblue
Copy link
Member

rwjblue commented Sep 28, 2016

Thanks for reporting! Can you share the full stack trace?

@estshy
Copy link
Author

estshy commented Sep 28, 2016 •
edited

Yes, for sure.

undefined: Cannot read property 'tag' of undefined ((..)/template): 
`TypeError: Cannot read property 'tag' of undefined
  at BasePlugin.LogStaticStrings._getBareStringAttribute (/ember-app/node_modules/ember-template-lint/lib/rules/lint-bare-strings.js:134:39)
  at BasePlugin.TextNode (/ember-app/node_modules/ember-template-lint/lib/rules/lint-bare-strings.js:111:16)
  at invokeVisitorEnter (/ember-app/node_modules/ember-template-lint/lib/rules/base.js:14:15)
  at visitor.enter (/ember-app/node_modules/ember-template-lint/lib/rules/base.js:83:11)
  at visitNode (/ember-app/node_modules/htmlbars/dist/cjs/htmlbars-syntax/traversal/traverse.js:18:28)
  at visitKey (/ember-app/node_modules/htmlbars/dist/cjs/htmlbars-syntax/traversal/traverse.js:55:19)
  at visitNode (/ember-app/node_modules/htmlbars/dist/cjs/htmlbars-syntax/traversal/traverse.js:25:7)
  at visitArray (/ember-app/node_modules/htmlbars/dist/cjs/htmlbars-syntax/traversal/traverse.js:71:18)
  at visitKey (/ember-app/node_modules/htmlbars/dist/cjs/htmlbars-syntax/traversal/traverse.js:53:5)
  at visitNode (/ember-app/node_modules/htmlbars/dist/cjs/htmlbars-syntax/traversal/traverse.js:25:7)
  at visitArray (/ember-app/node_modules/htmlbars/dist/cjs/htmlbars-syntax/traversal/traverse.js:71:18)
  at visitKey (/ember-app/node_modules/htmlbars/dist/cjs/htmlbars-syntax/traversal/traverse.js:53:5)
  at visitNode (/ember-app/node_modules/htmlbars/dist/cjs/htmlbars-syntax/traversal/traverse.js:25:7)
  at Object.traverse (/ember-app/node_modules/htmlbars/dist/cjs/htmlbars-syntax/traversal/traverse.js:110:3)
  at BasePlugin.transform (/ember-app/node_modules/ember-template-lint/lib/rules/base.js:41:17)
  at Object.preprocess (/ember-app/node_modules/htmlbars/dist/cjs/htmlbars-syntax/parser.js:45:25)
  at compileSpec (/ember-app/node_modules/htmlbars/dist/cjs/htmlbars-compiler/compiler.js:39:35)
  at compile (/ember-app/node_modules/htmlbars/dist/cjs/htmlbars-compiler/compiler.js:88:46)
  at Linter.verify (/ember-app/node_modules/ember-template-lint/lib/index.js:86:7)
  at TemplateLinter.processString (/ember-app/node_modules/ember-cli-template-lint/broccoli-template-linter.js:91:28)
  at Promise.then.result.output (/ember-app/node_modules/broccoli-persistent-filter/lib/strategies/persistent.js:41:23)
  at lib$rsvp$$internal$$initializePromise (/ember-app/node_modules/rsvp/dist/rsvp.js:541:9)
  at new lib$rsvp$promise$$Promise (/ember-app/node_modules/rsvp/dist/rsvp.js:757:9)
  at /ember-app/node_modules/broccoli-persistent-filter/lib/strategies/persistent.js:40:18
  at lib$rsvp$$internal$$tryCatch (/ember-app/node_modules/rsvp/dist/rsvp.js:493:16)
  at lib$rsvp$$internal$$invokeCallback (/ember-app/node_modules/rsvp/dist/rsvp.js:505:17)
  at lib$rsvp$$internal$$publish (/ember-app/node_modules/rsvp/dist/rsvp.js:476:11)
  at lib$rsvp$asap$$flush (/ember-app/node_modules/rsvp/dist/rsvp.js:1198:9)
  at doNTCallback0 (node.js:417:9)
  at process._tickCallback (node.js:346:13)

@rwjblue rwjblue added the bug label Nov 5, 2016
@rwjblue rwjblue mentioned this issue Nov 8, 2016
Merged
@estshy
Copy link
Author

estshy commented Nov 11, 2016 •
edited

@rwjblue The problem persists in v0.6.1

<md-autocomplete-wrap id= {{autocompleteWrapperId}} role="listbox" layout="row" class="{{if notFloating "md-whiteframe-z1"}} {{if notHidden "md-menu-showing"}}"></md-autocomplete-wrap>

undefined: Cannot read property 'tag' of undefined (input-language-autocomplete/template): 
`TypeError: Cannot read property 'tag' of undefined
  at BasePlugin.LogStaticStrings._getBareStringAttribute (ember-app/node_modules/ember-template-lint/lib/rules/lint-bare-strings.js:134:39)
  at BasePlugin.TextNode (ember-app/node_modules/ember-template-lint/lib/rules/lint-bare-strings.js:111:16)
  at invokeVisitorEnter (ember-app/node_modules/ember-template-lint/lib/rules/base.js:14:15)
  at visitor.enter (ember-app/node_modules/ember-template-lint/lib/rules/base.js:83:11)
  at visitNode (ember-app/node_modules/htmlbars/dist/cjs/htmlbars-syntax/traversal/traverse.js:18:28)
  at visitKey (ember-app/node_modules/htmlbars/dist/cjs/htmlbars-syntax/traversal/traverse.js:55:19)
  at visitNode (ember-app/node_modules/htmlbars/dist/cjs/htmlbars-syntax/traversal/traverse.js:25:7)
  at visitArray (ember-app/node_modules/htmlbars/dist/cjs/htmlbars-syntax/traversal/traverse.js:71:18)
  at visitKey (ember-app/node_modules/htmlbars/dist/cjs/htmlbars-syntax/traversal/traverse.js:53:5)
  at visitNode (ember-app/node_modules/htmlbars/dist/cjs/htmlbars-syntax/traversal/traverse.js:25:7)
  at visitArray (ember-app/node_modules/htmlbars/dist/cjs/htmlbars-syntax/traversal/traverse.js:71:18)
  at visitKey (ember-app/node_modules/htmlbars/dist/cjs/htmlbars-syntax/traversal/traverse.js:53:5)
  at visitNode (ember-app/node_modules/htmlbars/dist/cjs/htmlbars-syntax/traversal/traverse.js:25:7)
  at Object.traverse (ember-app/node_modules/htmlbars/dist/cjs/htmlbars-syntax/traversal/traverse.js:110:3)
  at BasePlugin.transform (ember-app/node_modules/ember-template-lint/lib/rules/base.js:41:17)
  at Object.preprocess (ember-app/node_modules/htmlbars/dist/cjs/htmlbars-syntax/parser.js:45:25)
  at compileSpec (ember-app/node_modules/htmlbars/dist/cjs/htmlbars-compiler/compiler.js:39:35)
  at compile (ember-app/node_modules/htmlbars/dist/cjs/htmlbars-compiler/compiler.js:88:46)
  at Linter.verify (ember-app/node_modules/ember-template-lint/lib/index.js:86:7)
  at TemplateLinter.processString (ember-app/node_modules/ember-cli-template-lint/broccoli-template-linter.js:91:28)
  at Promise.then.result.output (ember-app/node_modules/broccoli-persistent-filter/lib/strategies/persistent.js:41:23)
  at initializePromise (ember-app/node_modules/rsvp/dist/rsvp.js:588:5)
  at new Promise (ember-app/node_modules/rsvp/dist/rsvp.js:1076:31)
  at ember-app/node_modules/broccoli-persistent-filter/lib/strategies/persistent.js:40:18
  at tryCatch (ember-app/node_modules/rsvp/dist/rsvp.js:538:12)
  at invokeCallback (ember-app/node_modules/rsvp/dist/rsvp.js:553:13)
  at publish (ember-app/node_modules/rsvp/dist/rsvp.js:521:7)
  at flush (ember-app/node_modules/rsvp/dist/rsvp.js:2373:5)
  at doNTCallback0 (node.js:417:9)
  at process._tickCallback (node.js:346:13)

@rwjblue rwjblue reopened this Nov 11, 2016
@rwjblue rwjblue mentioned this issue Jun 22, 2017
Merged
bjornharrtell pushed a commit to bjornharrtell/ember-template-lint that referenced this issue Jun 11, 2019
@ynnoj
✨ Remove Basscss dependency for component CSS (ember-template-lint#112)
20e4fa1 
Fixes ember-template-lint#102

📦 Component and template cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwjblue @estshy