Ensure TextNode
s are quoted in AttrNode.value
#135
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when converting an
AttrNode
fromdata-foo={{anything}}
todata-foo="some text"
we would not emit quotes surrounding the newAttrNode
value, and therefore would emit invalid HTML/HBS output.This problem was restricted to scenarios where the original
AttrNode
's value was unquoted (e.g. it was a mustache value).Fixes #111