Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use execa instead of child_process.spawn in tests. #145

Merged
merged 2 commits into from Oct 16, 2019
Merged

Use execa instead of child_process.spawn in tests. #145

merged 2 commits into from Oct 16, 2019

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Oct 16, 2019

Using child_process makes cross platform testing much harder, also
execa already provides exactly the API we wanted 馃槃

@rwjblue rwjblue merged commit 36b9976 into ember-template-lint:master Oct 16, 2019
@rwjblue rwjblue deleted the use-execa branch October 16, 2019 13:42
@rwjblue rwjblue changed the title Use execa instead of child_process.spawn Use execa instead of child_process.spawn in tests. Oct 16, 2019
@rwjblue rwjblue changed the title Use execa instead of child_process.spawn in tests. Use execa instead of child_process.spawn in tests. Oct 16, 2019
This was referenced Oct 16, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rwjblue