Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ember-template-recast bin script file selection for Windows users #147

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Fix ember-template-recast bin script file selection for Windows users #147

merged 1 commit into from
Oct 16, 2019

Commits on Oct 16, 2019

  1. Avoid issues with non-posix paths with globby 

    globby uses the fast-glob package, which states this in its README (RE:
patterns):

> ⚠️ Always use forward-slashes in glob expressions (patterns and ignore
> option). Use backslashes for escaping characters.

Previously, we were using `path.join` which will use the OS specific
separator and therefore fail to match files when invoked with a
directory path directly.

globby has an explicit API that allows us to avoid doing this
`path.join` at all (`expandDirectories`). This changes to use that,
remove the manual joining.

---

This also corrects for a bug in globby (to be reported/fixed separately)
where the `cwd` option is defaulted to `process.cwd()` _without_ posix
correction, and then subsequently an assertion is made that a given path
"starts with" the cwd.
    @rwjblue
    rwjblue committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    1398dcb View commit details
    Browse the repository at this point in the history