Fix invalid recursive dirtying when mutating nodes (significant performance improvement). #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, ember-template-recast is getting hung up on deeply nested trees with lots of changes. It appears markAsDirty(), which should traverse all its parents, is making a bunch of additional recursions that aren't necessary. This change updates the logic so it strictly visits its ancestors only.
rwjblue
reviewed
Oct 17, 2019
|
Afraid I'm not sure if there's any meaning or intent behind the double-loop. As far as I can tell, the additional work is superfluous, but I might be missing something. The good news is that updating this means scripts using ember-template-recast won't get stuck when processing deeply nested nodes, as well as other operations in general appear to run much faster. ^_^ |
rwjblue
approved these changes
Oct 17, 2019
rwjblue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, ember-template-recast is getting hung up on deeply nested
trees with lots of changes. It appears markAsDirty(), which should traverse all its parents,
is making a bunch of additional recursions that aren't necessary.
This change updates the logic so it strictly visits its ancestors only.