fix: Make it possible to annotate nodes #154
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a test that fails with this error:
It looks impossible to annotate an
else if
node right now. The type of the node is BlockStatement.This is an issue I ran into while switching to use
ember-template-recast
inember-template-lint
. The rule involved there is:lint-block-indentation
.I'm not quite sure in which direction to go. I see two options: 1/ refactor the visitor on
ember-template-lint
side to annotate the node in a different way; 2/ fix the annotation here inember-template-recast
. I would go for the second option, but may you confirm @rwjblue?EDIT: added the error stacktrace