fix(print): fix print for NullLiteral #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentMolinie
force-pushed
the
fix/null-literal-print
branch
from
960fc6f
to
be1b4c3
Compare
|
@dcyriller may be you can help me 馃懠 |
bmish
reviewed
Jan 11, 2022
dcyriller
reviewed
Jan 11, 2022
This reverts commit be1b4c3.
bmish
approved these changes
Jan 12, 2022
|
It's never passing into my code. My test is actually wrong 馃槥 |
|
I finally found a way to reproduce the issue. It's when you are deleting or setting something on the node |
rwjblue
requested changes
Jan 12, 2022
rwjblue
approved these changes
Jan 13, 2022
|
I can't merge. I let you do it 馃懠 |
dcyriller
approved these changes
Jan 13, 2022
|
@bmish can you merge it and create a patch ? 馃檹 |
|
@dcyriller want to release it? If you can't get to it, I might be able to try later today. |
|
It is released in v6.1.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bmish I tried with this fix it seems the test for PR ember-template-lint/ember-template-lint#2271 on
{{contact-null null}}pass. I don't know how it was working before 馃