Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement get_sys_path() and dev node iterator for virtual devices #72
implement get_sys_path() and dev node iterator for virtual devices #72
Changes from 1 commit
65af550
a0cba43
d617c90
4139639
353fa96
e218dfc
fc0ee43
3c39900
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bit of a further nit, but can we either ungate this or gate this behind a
blocking
feature? In a single binary if one crate user were to definetokio
and another does not it'll really confuse cargo. I'd like to make sure that if someone really wants to they could build and use both simultaneously.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right, it makes sense to not even have the feature gate there if we are differentiating them anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will need to somehow disambiguate the two
DevNodes
structs as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right. I had a much better look now and fixed a few other things too:
fs
feature flag to the tokio dependency, socargo b --features tokio
actually works..await?
, the async version of the iterator is dealing with justOption<T>
which simplifies the code.DevNodes
variant for the sync version toDevNodesBlocking
so they can co-exist.With the tokio feature flag, one should have access to both the sync and async versions.