-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for button groups #47
Comments
I don't think btn-group would be a good addition. It is only an html tag, which has no use for any binding attribute. |
@dmathieu But it does have a useful binding: selected button! I would rather use one control with a single-variable binding than do jquery magic to figure out which of the buttons from the group is selected. It's actually quite similar to the dropdown list with options in this sense. |
I don't see any change, visible nor in the dom in the bootstrap documentation for the selected button in btn-group. Anyway, selected button or not, the problem remains the same. This would be one very big handlebars helper with a lot of parameters in it, which would be very hardly usable. |
Selected button has 'active' class added to it. Why should the helper be big? How is list of buttons in div tag different from list of options in select tag? |
Buttons are components by themselves. An option in a select tag is only an array entry, which doesn't behaves as a component by itself. It exists only because it is wrapped around a select tag, which controls it. |
Yes, that's true, but I think it's ok to not support the full button's functionality for each individual button in a group. Some helper is better than no helper and the ability to bind to the currently selected button(s) is very useful in itself. |
@dmathieu : Hi, navigation bars are in this category too? I mean: are too complex of implement or otherwise they can be implemented in another way? Can be used a mix of ember-bootstrap and twitter-bootstrap.js itself in the same project? |
@diosney: I think navigation bars could be implemented. And yes ember bootstrap and the native twitter bootstrap libraries can be used together. |
Sure, I will file a new issue with the navigation request. Thanks. |
Hmm, I read progress bar, foolish me. Look at modalPane for example. |
Oh! I see. Thanks anyway, I will close the issue then referencing this one. |
Closing this one too. If you have an implementation to propose, please open a pull request. |
…dates bootstrap markup (fixes emberjs-addons#47)
One particular UI element is missing - button groups:
I should support both "buttons-checkbox" and "buttons-radio" toggle styles.
The text was updated successfully, but these errors were encountered: