Replace Identifier only if key and value are different in the scope #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candunaj
force-pushed
the
remap-identifiers-fix
branch
from
1259c00
to
28a6aab
Compare
|
Oh yeah! Babel will rerun the visitors on the newly inserted code, so that makes sense. |
|
Released in 2.0.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes "maximum call stack exception" when the template is transpiled into the glimmer wire format and there is scope with some different and some equal keys.
There was a problem when the key and value were equal in the scope. Identifier was replaced with the same Identifier so there was a "Maximum call stack exception".