didLoad should fire even if the record isEmpty

Fixes #1317
emberjs · Sep 19, 2013 · a29dbcf · a29dbcf
1 parent 14cd3e3
commit a29dbcf
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/packages/ember-data/lib/system/model/states.js b/packages/ember-data/lib/system/model/states.js
@@ -446,6 +446,7 @@ var RootState = {
 
     pushedData: function(record) {
       record.transitionTo('loaded.saved');
+      record.triggerLater('didLoad');
     }
   },
 

diff --git a/packages/ember-data/tests/unit/store/push_test.js b/packages/ember-data/tests/unit/store/push_test.js
@@ -51,6 +51,20 @@ test("Calling push with a normalized hash returns a record", function() {
   }));
 });
 
+test("Calling push triggers `didLoad` even if the record hasn't been requested from the adapter", function() {
+  Person.reopen({
+    didLoad: async(function() {
+      ok(true, "The didLoad callback was called");
+    })
+  });
+
+  store.push('person', {
+    id: 'wat',
+    firstName: "Yehuda",
+    lastName: "Katz"
+  });
+});
+
 test("Calling update with partial records updates just those attributes", function() {
   var person = store.push('person', {
     id: 'wat',