Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for passing a query of type array to store.find. #1740

Closed
wants to merge 2 commits into from

Conversation

arjand
Copy link

@arjand arjand commented Feb 11, 2014

Since the query is passed directly to jQuery, this array follows
the format as specified by jQuery.param.

Use Case:
I need to send multiple filter requests to the server. Since the query is passed to jQuery, jQuery.param() is responsible for serializing the array. http://api.jquery.com/jQuery.param/
The example I added to the documentation follows jQuery's serializeArray() convention.

Since the query is passed directly to jQuery, this array follows
the format as specified by jQuery.param.
@arjand
Copy link
Author

arjand commented Feb 15, 2014

Here is a a jsbin that shows these changes working with a custom built version of Ember Data:
http://jsbin.com/nonaf/1/edit

I believe I followed the Pull Request instructions in the contributing instructions, but as this is my first pull request to Ember Data please let me know what other steps I should take.

@arjand arjand closed this Feb 19, 2014
@arjand arjand reopened this Feb 20, 2014
@igorT
Copy link
Member

igorT commented May 20, 2014

Thanks for the PR! I don't feel comfortable merging this by myself, but I think it looks good to me.

@arjand
Copy link
Author

arjand commented Jul 17, 2014

Let me know if there's any information I can provide to help make sure it is ok.
I'd like to see this merged so I don't have to keep building a custom version of Ember Data. :)

@sly7-7
Copy link
Contributor

sly7-7 commented Dec 16, 2014

@igorT Do you feel comfortable enough now?

@wecc
Copy link
Contributor

wecc commented Feb 11, 2015

Relevant: emberjs/rfcs#27

@igorT
Copy link
Member

igorT commented Jun 9, 2015

We have deprecated the overloaded find, and now you should be able to pass an array to store.query

@igorT igorT closed this Jun 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants