Deprecate App.Store in favor of App.ApplicationStore. #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the application level store lookup much closer to the reset of our conventions (ala `App.ApplicationAdapter` and `App.ApplicationSerializer`). This change also allows specifying a custom store when using non-global resolver (i.e. EAK/ember-cli). Previously, we were only looking for a property `Store` hung off of the application instance. Now you can have a module named (in the case of stock EAK setup): `app/stores/application` or `app/application/store.js` (pods structure). A deprecation warning was added, and the prior technique still works so this is not a breaking change (although I believe that we should remove before the prior lookup prior to 1.0).
|
👍 always welcome consistency! |
|
this does clearup naming collisions, especially if you have a store model |
|
@wycats - Thoughts? |
|
👍 App.ApplicationStore is was what I would have assumed anyway. Glad I saw this! |
|
👍 given in core team meeting on 2014-03-21. |
rwjblue
added a commit
that referenced
this pull request
Mar 23, 2014
Deprecate App.Store in favor of App.ApplicationStore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the application level store lookup much closer to the reset of our conventions (ala
App.ApplicationAdapterandApp.ApplicationSerializer).This change also allows specifying a custom store when using non-global resolver (i.e. EAK/ember-cli). Previously, we were only looking for a property
Storehung off of the application instance. Now you can have a module named (in the case of stock EAK setup):app/stores/applicationorapp/application/store.js(pods structure).A deprecation warning was added, and the prior technique still works so this is not a breaking change (although I believe that we should remove before the prior lookup prior to 1.0).