Embedded associations need special handling in Model.dataDidChange

[ghempton]

This is a fix for #218.

[envone]

+1, I have made similar code, seems clean.

[mixonic]

Oh +1 +1! I spent too much time hung up on this. I've got something like this locally:

https://github.com/mixonic/data/compare/read_embedded_has_many_association_from_data_on_parent_data_update

But this code looks better, and tested.

[guilhermeaiolfi]

Hi @ghempton, I tried your changes and it's not fully working for me.
I have a simple form that lists the hasMany relationship records. Like in: Parent hasMany Children, so:

{{view Em.TextField valueBinding="Parent.FieldOne"}}
{{view Em.TextField valueBInding="Parent.FieldTwo"}}
{{#each Child in Parent.Children}}
   {{Child.FieldChild}}
{{/each}}

After change some data in Parent and commiting those changes. The each helper doesn't show any children anymore.

Here are the object I get before commiting:

__ember1338575163426: "ember1204"
__ember1338575163426_meta: Object
_super: undefined
get content: function (){return n(this,a)}
recordCache: Array[2]
set content: function (){this instanceof Ember.Object&&!this.isDestroyed}
store: i
type: App.Telephone
__proto__: Object

After commiting:

__ember1338575163426: "ember1204"
__ember1338575163426_meta: Object
_super: undefined
get content: function (){return n(this,a)}
recordCache: Array[0]
set content: function (){this instanceof Ember.Object&&!this.isDestroyed}
store: i
type: App.Telephone
__proto__: Object

See the recordCache property. I don't know what {{each}} uses to list the records but after commiting the recordCache is gone.

[guilhermeaiolfi]

The comment above should have been gone in #256, that was the changes I tested against.

[wagenet]

I just committed a fix that handles part of what you did here. However, it looks like you also cover some other cases. Can you rebase this? Thanks!

[wagenet]

I think this fix is better than mine. Will revert my change and pull this instead.