Fix computed properties for embedded hasMany relationships (fixes #191) #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where: - a model A `hasMany` model B's, - the model B objects are embedded in a model A object, and - model A has a computed property that depends on *a property of* the hasMany association. In such a case, what should have been the IDs of the embedded model B objects were actually the objects themselves, which was causing problems. This bug is fixed now and covered by a new test.
|
This works for me. The test is nearly identical to mine that recently started failing. Also works for non-id primary keys. |
|
I prefer #218 where the embedded data is actually used, instead of just stripped out and re-fetched. |
|
Sorry, I mean the pull request of #248 - there are a few fixed for this floating around, I got them mixed up. |
|
Whoops, I should have checked the open PRs first. I just committed a fix for this. Thanks though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes Issue #191, where:
hasManymodel B's,hasMany association.
In such a case, what should have been the IDs of the embedded model B
objects were actually the objects themselves, which was causing
problems.
This bug is fixed in this commit and covered by a new test.