Rely on active model serializer to handle error logic #3076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 17, 2015 20:17
The changes in e928355 doesn't make the behaviour as backwards compatible as we would like. The changes would break existing systems that do depend on a snake case errors hash as we've seen in #3067. For now restore the original behaviour so that we can make a release. We should make a decision at some point whether to use the documented interface for `InvalidError` or to change the interface. Part of the issue here is that we don't have an integration test to qualify that the errors hash gets read correctly and camelized. There's been some confusion as to whether or not ember data actually does this.
Thanks to @pangratz for putting this test together. Currently we only have tests for the adapter and serializer correctly behaving in isolation.
fivetanley
added a commit
that referenced
this pull request
May 18, 2015
Rely on active model serializer to handle error logic
|
thanks! 🎉 |
|
👍 |
|
😍 |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reverts the changes in #3030, I'd overlooked the role AMS played in error handling and got distracted by some broken tests. Sorry guys.
Kudos to @pangratz for putting together an integration test to make sure the errors hash does indeed get passed through correctly and camelized as expected.
Fixes #3067, cc @fivetanley