Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rely on active model serializer to handle error logic #3076

Merged
merged 2 commits into from May 18, 2015
Merged

Rely on active model serializer to handle error logic #3076

merged 2 commits into from May 18, 2015

Commits on May 18, 2015

  1. Pass through the parsed response directly again 

    The changes in e928355 doesn't make the behaviour as backwards compatible as
we would like. The changes would break existing systems that do depend on a
snake case errors hash as we've seen in #3067.

For now restore the original behaviour so that we can make a release. We should
make a decision at some point whether to use the documented interface for
`InvalidError` or to change the interface.

Part of the issue here is that we don't have an integration test to qualify that
the errors hash gets read correctly and camelized. There's been some confusion
as to whether or not ember data actually does this.
    Ben Holmes committed May 18, 2015
    Configuration menu
    Copy the full SHA
    375e980 View commit details
    Browse the repository at this point in the history

  2. Test that active model adapter passes errors to serializer 

    Thanks to @pangratz for putting this test together. Currently we only have tests
for the adapter and serializer correctly behaving in isolation.
    Ben Holmes committed May 18, 2015
    Configuration menu
    Copy the full SHA
    17a2a18 View commit details
    Browse the repository at this point in the history