Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup the store using store:application instead of store:main #3136

Merged
merged 1 commit into from
Jun 3, 2015

Conversation

bmac
Copy link
Member

@bmac bmac commented Jun 1, 2015

This simplifes the process of registering the store when a user
creates a custom one. This change also fixes deprecations warning
introduces in Ember 1.12. The store service is now injected as a
instanceInitializer.

@igorT
Copy link
Member

igorT commented Jun 2, 2015

Can @rwjblue or @stefanpenner review?

This simplifes the process of registering the store when a user
creates a custom one.  This change also fixes deprecations warning
introduces in Ember 1.12. The store service is now injected as a
instanceInitializer.
@rwjblue
Copy link
Member

rwjblue commented Jun 2, 2015

  • store:main will still work, with a deprecation in favor of store:application.
  • store:application worked in prior versions

Looks good to me. We should probably update any docs that reference 'app/store.js' in favor of 'app/stores/application.js' (both here and in the guides).

@bmac bmac changed the title Lookup the store using store:application instead of application:main Lookup the store using store:application instead of store:main Jun 2, 2015
tarzan added a commit to tarzan/data that referenced this pull request Jun 2, 2015
@bmac
Copy link
Member Author

bmac commented Jun 3, 2015

@rwjblue I searched through the guides and the API docs and couldn't find any instance of 'app/store.js' (which should have already given a deprecation message).

app/stores/application.js has been the recommend path for a while, however most of the docs that describe how to do it are still using globals so it looks like App.ApplicationStore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants