more cleanup on internalModel vs record #3147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -115,7 +115,7 @@ export default Serializer.extend({ | |||
| */ | |||
| applyTransforms: function(typeClass, data) { | |||
| typeClass.eachTransformedAttribute(function applyTransform(key, typeClass) { | |||
| if (!data.hasOwnProperty(key)) { return; } | |||
| if (!(key in data)) { return; } | |||
There was a problem hiding this comment.
This data comes from jqxhr afaik, so can't do this
There was a problem hiding this comment.
You right let's leave serializable hash alone for now. I removed the changes.
tchak
force-pushed
the
internal-model-cleanup
branch
from
d62166b
to
5145f1a
Compare
tchak
force-pushed
the
internal-model-cleanup
branch
from
5145f1a
to
e5de2c5
Compare
|
|
||
| toString: function() { | ||
| if (this.record) { | ||
| return this.record.toString(); |
igorT
added a commit
that referenced
this pull request
Jun 2, 2015
more cleanup on internalModel vs record
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.