Refactor Errors#errorsByAttributeName to not use Ember.reduceComputed
#3329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -297,6 +284,7 @@ export default Ember.Object.extend(Ember.Enumerable, Ember.Evented, { | |||
|
|
|||
| var content = get(this, 'content').rejectBy('attribute', attribute); | |||
| get(this, 'content').setObjects(content); | |||
| get(this, 'errorsByAttributeName').remove(attribute); | |||
There was a problem hiding this comment.
isn't map.remove also deprecated?
There was a problem hiding this comment.
There was a problem hiding this comment.
Your're absolutely right, nice catch! Will update to use delete...
There was a problem hiding this comment.
So this would have been caught by Travis we would need to run the tests using a debug build of Ember, right?
There was a problem hiding this comment.
c, it seems like we should do that.
There was a problem hiding this comment.
Hmm, as far as I can see the debug builds are already used ... 😕
There was a problem hiding this comment.
This is because currently the RAISE_ON_DEPRECATION env is not set to true, which is tracked in #3233
igorT
added a commit
that referenced
this pull request
Jun 14, 2015
Refactor `Errors#errorsByAttributeName` to not use Ember.reduceComputed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember.reduceComputedhas been deprecated in emberjs/ember.js#11403. Once this is merged, #3327 can be closed.