Don’t crash \w Ember 2.0

[stefanpenner]

There may be more, but this at-least makes my one app work correctly.

• instead of poluting the Ember object, we should instead add a level of indirection by moving the polifills to a local module, and doing the funky work there.

Goal:

to ease upgrade pain for people

[stefanpenner]

this seems to be failing related to some build tool stuff.

[ghost]

Got the build working again: stefanpenner#8.

Will open another PR for demonstration purposes.

[stefanpenner]

@mkorfmann awesome thanks.

@bmac / @igorT / @fivetanley / @wecc need anything else on this?

[ghost]

I was a a bit too quick, some tests seem to be failing.

[ghost]

Currently investigating...

[ghost]

All tests pass, except for this:

383) DS.DebugAdapter: global failure Error: Could not find module ember-data/ext/ember/array

Any clues?

Adding fuel to the fire, this error is only appearing when running the tests in the terminal, no problems running the tests in the browser.

[stefanpenner]

i'll take a look now.

[stefanpenner]

Adding fuel to the fire, this error is only appearing when running the tests in the terminal, no problems running the tests in the browser.

which version of phantom are you using?

2.0 + 1.9 appear to work fine for me.

[ghost]

I'm using 1.9 as well. Haven't tried with 2.0.

[stefanpenner]

I'm using 1.9 as well. Haven't tried with 2.0.

which patch level?

[ghost]

Good question, I'm not sure how I can obtain the patch level information from my current pjs installation.

But the travis build threw the same error: https://travis-ci.org/emberjs/data/builds/76207796.

[ghost]

Thats what I got from running dpkg -s phantomjs | grep Version: Version: 1.9.0-1.

[stefanpenner]

locally 1.9.2 1.9.8 and 2.0.0 appear to work..
hmm

[ghost]

Weird, I'm having the same issue with pjs 2.0.0 as well.

Probably not a phantomjs issue.

[bmac]

@stefanpenner I just noticed the v1.13 branch was extremely out of date from the release branch. I just synced them do you mind rebasing this pr?

[stefanpenner]

@bmac rebased

found the test failure, working on it. (its prod mode only fairly)

[stefanpenner]

i think i got it, lets see what travis has to say.

[wecc]

🎉

[ghost]

Nice!

[ghost]

That was a tough one... At least for me :).

[stefanpenner]

@mkorfmann ya, so. I realized the the prod builds of ember-data tests don't have module access to ember-data itself (they should but its just a quirk of the more aggressive code folding used in prod)

[stefanpenner]

alright looks like this is good to go.

[ghost]

@stefanpenner Good to know, thanks for explaining.