Fixing typo that causes Ember-Data v1.13.10 to crash with Ember v2.0. #3685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for catching this @workmanw. Looking into the build failure now. |
|
Happy to help :) Let me know if there is anything else I can do to kick it along. |
|
ROFL, |
|
@stefanpenner @bmac At first I was scratching my head at how that even passed the tests, but because they're run against Ember 1.13, it was just falling back to the |
|
Build should be fixed. @workmanw do you mind rebasing your pr now? |
|
Done 🍻 |
bmac
added a commit
that referenced
this pull request
Aug 21, 2015
Fixing typo that causes Ember-Data v1.13.10 to crash with Ember v2.0.
|
Thanks @workmanw. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.