[BUGFIX release-1-13] Disable polymorphic deserialization when a mode… #3725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XrXr
force-pushed
the
disable-polymorphic-for-type-atrr
branch
2 times, most recently
from
4f4e4b8
to
da4c68c
Compare
…l expects a type attribute b7f7b7a introduced a bug where if there is a type key in a payload that is part of an array, it would be used for polymorphic deserialization even when the model expects an attribute that is named "type". Interestingly, for such payloads, `arrayHash` passed into `normalizeArray()` in rest-serializer.js contains Ember.Object instances as opposed to plain objects. This causes the code to throw, since `hash.type` would be a computed property in that case. This is probably because of extending from JSONAPISerializer.
XrXr
force-pushed
the
disable-polymorphic-for-type-atrr
branch
from
da4c68c
to
a117f01
Compare
|
LGTM 👍 |
bmac
added a commit
that referenced
this pull request
Sep 10, 2015
[BUGFIX release-1-13] Disable polymorphic deserialization when a mode…
bmac
added a commit
that referenced
this pull request
Sep 21, 2015
Port pr #3725 to the release 2.0 branch
|
Something worth considering that looks like it could still be an issue: consider the scenario where the a It looks like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…l expects a type attribute
b7f7b7a introduced a bug where if there is a type key in a payload that is part
of an array, it would be used for polymorphic deserialization even when the
model expects an attribute that is named "type".
Interestingly, for such payloads,
arrayHashpassed intonormalizeArray()inrest-serializer.js contains Ember.Object instances as opposed to plain objects.
This causes the code to throw, since
hash.typewould be a computed propertyin that case instead of a string that
dasherizeexpects. This is probably becauseof extending from JSONAPISerializer.
Fixes #3702.
It probably also fixes #3724, but needs a port to 2.0