Trigger an assertion when calling findRecord with falsy (except 0) id
#3795
Conversation
| @@ -1,3 +1,5 @@ | |||
| import { badIdFormatAssertion } from 'ember-data/system/store'; | |||
There was a problem hiding this comment.
This causes an error:
706 tests complete (9256 ms)
706) integration/snapshot - DS.Snapshot: global failure
Error: Could not find module ember-data/system/store
Is there any other way I can import exported module variables? I wonder why I can't use normal import like in HTMLBars. I also haven't found any example of using import in unit tests. I doubt they are real unit tests if they have access to all global namespaces, no imports. Is this because of old Ember CLI version?
PS: Tests on my local machine pass, appveyor build runs fine, only travis errors.
There was a problem hiding this comment.
I think this is a limitation of our testing infrastructure. Modules can be access in dev mode but the production build (which I suspect travis is using) wraps Ember Data's module loader in a closure so tests (or user code) can't get at internal paths like 'ember-data/system/store'.
There was a problem hiding this comment.
Ok, I'll try to work around this. Do you plan to fix this in future?
|
Tests pass. |
|
Looks good @kuzirashi. Do you mind squashing this pr into 1 commit? |
|
Commits squashed. @bmac |
|
Ping @bmac :S hope you notice and see if there's anything for this pr to get merged or you just didn't notice it. :P |
Trigger an assertion when calling `findRecord` with falsy (except 0) id
|
Thanks @kuzirashi. |
Attempt to close #2348. Do you think it is sufficient or should
Ember.Errorbe thrown as @stefanpenner suggested here?