Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Do not deserialize when a relationship named type exists #3814

Merged
merged 1 commit into from
Oct 3, 2015

Conversation

andycrum
Copy link
Contributor

@andycrum andycrum commented Oct 2, 2015

69dca0c fixed this for attributes named type, but the RESTSerializer
was still trying to deserialize relationships with that name as
polymorphic, which was causing errors for anyone having a domain
model called "Type".

cc @bttf @bmac

69dca0c fixed this for attributes named 'type', but the RESTSerializer
was still trying to deserialize relationships with that name as
polymorphic, which was causing errors for anyone having a domain
model called "Type".
@andycrum
Copy link
Contributor Author

andycrum commented Oct 2, 2015

I believe this fixes #3784

@bmac
Copy link
Member

bmac commented Oct 3, 2015

Looks great. Thanks @andycrum.

bmac added a commit that referenced this pull request Oct 3, 2015
[BUGFIX] Do not deserialize when a relationship named `type` exists
@bmac bmac merged commit e8b426e into emberjs:master Oct 3, 2015
@jevanlingen
Copy link

👍

@jevanlingen
Copy link

Btw, can this fix be applied to the 1.13.x branche too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants