[BUGFIX] Do not deserialize when a relationship named type exists
#3814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69dca0c fixed this for attributes named 'type', but the RESTSerializer was still trying to deserialize relationships with that name as polymorphic, which was causing errors for anyone having a domain model called "Type".
|
I believe this fixes #3784 |
|
Looks great. Thanks @andycrum. |
bmac
added a commit
that referenced
this pull request
Oct 3, 2015
[BUGFIX] Do not deserialize when a relationship named `type` exists
|
👍 |
|
Btw, can this fix be applied to the 1.13.x branche too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
69dca0c fixed this for attributes named
type, but the RESTSerializerwas still trying to deserialize relationships with that name as
polymorphic, which was causing errors for anyone having a domain
model called "Type".
cc @bttf @bmac