Backport Fix usage of registry for 2.1.0+ from pr #3665 #3840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[BUGFIX] Restore IE8 compatibility by using Ember.create
Using `registry.resolve` is generally private API, and `container.lookupFactory` provides roughly the same result. We still need the registry to actually register the model we create, so I added a small matrix inline (this was the only usage of accessing the registry off of `this.container` that I found in the codebase). (cherry picked from commit 64ccbc3)
This was previously passing, because Ember 2.0.0 and lower did not properly rethrow the error in all circumstances. (cherry picked from commit b6498c4)
| // container._registry = 1.11 - 2.0 | ||
| // container = < 1.11 | ||
| var registry = this.container.registry || this.container._registry || this.container; | ||
| var mixin = this.container.lookupFactory('mixin:' + normalizedModelName); |
There was a problem hiding this comment.
Need to double check that container.lookupFactory has existed since 1.8 before this can be merged.
There was a problem hiding this comment.
Does https://github.com/emberjs/ember.js/blob/v1.8.0/packages/container/lib/container.js#L322 is enough to confirm ?
|
👍 |
bmac
force-pushed
the
release-1-13
branch
3 times, most recently
from
daa8774
to
0f3c4d1
Compare
bmac
added a commit
that referenced
this pull request
Oct 16, 2015
Backport Fix usage of registry for 2.1.0+ from pr #3665
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.