Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] update ember-inflector to resolve default Inflector … #3887

Merged
merged 1 commit into from
Oct 27, 2015

Conversation

fivetanley
Copy link
Member

…issues

This should fix issues with handlebars helpers, see
emberjs/ember-inflector#90

…issues

This should fix issues with handlebars helpers, see
emberjs/ember-inflector#90
@fivetanley
Copy link
Member Author

I think this should fix #3881

@fsmanuel
Copy link
Contributor

@fivetanley 👍 will test it asap

@fsmanuel
Copy link
Contributor

@fivetanley i looked what you did in the PR https://github.com/stefanpenner/ember-inflector/pull/90/files and I think ember-data should do the same.

we should change:

import { pluralize, singularize } from 'ember-inflector/lib/system/string';
// to
import { pluralize, singularize } from 'ember-inflector';

@fivetanley
Copy link
Member Author

confirm. would you mind making a PR for that?

@fsmanuel
Copy link
Contributor

jup

bmac added a commit that referenced this pull request Oct 27, 2015
[BUGFIX release] update ember-inflector to resolve default Inflector …
@bmac bmac merged commit 4bdfabc into emberjs:master Oct 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants