[BUGFIX release] import from ember-inflector to use the default instance #3888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you amend the commit and PR title to be prefixed with |
fsmanuel
changed the title
fsmanuel
force-pushed
the
fix/inflector
branch
from
62ae6b1
to
38cbdeb
Compare
|
@fivetanley done |
fivetanley
added a commit
that referenced
this pull request
Oct 26, 2015
[BUGFIX release] import from ember-inflector to use the default instance
|
🎉 |
Closed
|
We're actually still having problems with this. I've locally applied this patch to 1.13.14 but I still have two inflector instances. This is probably caused by the fact that ember-cli-mirage also requires ember-inflector. Is there a reason ember-data bundles the inflector? |
|
Hey @joostdevries sorry for the late reply. Ember Data no longer bundles Ember inflector since 2.3 if you are using it as an ember cli addon. This change won't be backported to 1.x, sadly, as it will take a lot of effort. I backported the changes in this issue/PR to 1.13.16, let me know if that helps. #4143 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of importing from the path ember data should import from
ember-inflectorto use the default instance.related issues: #3887, #3881