Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use Ember.create by default #3891

Merged
merged 1 commit into from
Oct 27, 2015
Merged

Conversation

knownasilya
Copy link
Contributor

Fall back to Ember.create if Object.create is missing.

Fixes the deprecation coming back..

Fall back to Ember.create if Object.create is missing.
bmac added a commit that referenced this pull request Oct 27, 2015
Don't use Ember.create by default
@bmac bmac merged commit 8e713d5 into emberjs:release-1-13 Oct 27, 2015
@bmac
Copy link
Member

bmac commented Oct 27, 2015

Thanks @knownasilya

@knownasilya knownasilya deleted the patch-3 branch October 27, 2015 18:45
@knownasilya
Copy link
Contributor Author

Glad I could help.

@pangratz
Copy link
Member

Hmm, I thought Ember.create only shims the create functionality if it doesn't exist and uses Object.create if it's available? See https://github.com/emberjs/ember.js/blob/release-1-13/packages/ember-metal/lib/platform/create.js

With which version of Ember does which deprecation warning occur?

@rwjblue
Copy link
Member

rwjblue commented Oct 27, 2015

@pangratz - You are correct that the implementation of Ember.create was essentially a polyfil, but using Ember.create in Ember 1.13 will result in a deprecation (and it was removed in Ember 2.0).

@bmac
Copy link
Member

bmac commented Oct 27, 2015

For future reference the deprecation warning gets added here: https://github.com/emberjs/ember.js/blob/release-1-13/packages/ember-metal/lib/main.js#L423

@pangratz
Copy link
Member

Ah, thanks for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants