Move public modules out of the -private folder
#4029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's odd that most of these aren't showing up as moves. Did you use |
|
Otherwise it looks fine to me but it would be nice to preserve history if we could. (even if it requires |
|
I did use git mv originally. I think changing some of the imports is confusing github's display of the moves. git status shows several of these changes as a rename where github is making it look like a file was deleted. |
|
Ah nice. Seems like it needs |
fivetanley
added a commit
that referenced
this pull request
Dec 30, 2015
Move public modules out of the `-private` folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3998
cc @rwjblue @fivetanley