Replace calls to store.find with store.findRecord #4039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -543,7 +543,7 @@ InternalModel.prototype = { | |||
| came back from the server, except the user obtained them out of band and is informing | |||
| the store of their existence. The most common use case is for supporting client side | |||
| nested URLs, such as `/posts/1/comments/2` so the user can do | |||
| `store.find('comment', 2, {post:1})` without having to fetch the post. | |||
| `store.findRecord('comment', 2, {post:1})` without having to fetch the post. | |||
There was a problem hiding this comment.
I think this should be store.findRecord('comment', 2, { preload: { post: 1 } })
|
Nice @pangratz! Other than the comments above this LGTM |
bmac
added a commit
that referenced
this pull request
Jan 6, 2016
Replace calls to store.find with store.findRecord
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
store.findhas been deprecated in1.13and been officially removed in the2.xseries. This updates all references in the public documentation to usestore.findRecord. Also some tests were still usingstore.find(which is still available since it is needed in themodel()hook of Ember, but it is private now).