Use test helpers from ember dev

[pangratz]

This PR replaces the currently used test helpers to check for correct assertions, deprecations etcetera with the ones from emberjs/ember-dev.

This addresses #2456

---

TODO

• investigate why tests are not failing although ember-dev helper raises error
• fix failing test by wrapping this line in Ember.run
• decide if we want to use patched QUnit.module or our own module

[pangratz]

Hmm, looks like although the ember-dev helpers throw an error that one test has a pending run loop at the end, the build does not fail: https://travis-ci.org/pangratz/data/builds/100128108#L1023-L1032.

I am investigating...

[stefanpenner]

awesome

[pangratz]

Alright, so ember-dev is now used correctly. The failing test is expected since a run-loop is triggered here, but it is not wrapped within Ember.run.

The problem with the previous approach was that the ember-dev helpers were instantiated within QUnit.testStart() and tested in QUnit.testDone(). If an failing assertion is added within those callbacks, the corresponding test is not marked as failed.

---

The current, working approach patches the QUnit.module so the ember-dev helpers are setup and used in the beforeEach and afterEach hooks.

The question is now if we want to use the approach of a patched QUnit.module - like it is also done in ember-dev's setupQUnit - or if we want to use another approach, where we create a custom module and use this in all the tests:

// ember-data/tests/helpers/qunit.js
import { module } from "ember-qunit";

export default function(description, options = {}) {
  var originalBeforeEach = options.beforeEach || function() {};
  var originalAfterEach = options.afterEach || function() {};

  // ...

  return module(...arguments);
}

And use this module in all the tests (instead of import { module } from "ember-qunit";):

// ember-data/tests/integration/le-test.js
import module from "../helpers/qunit";
import { test } from "ember-qunit";

module("le module");

test("le test", function() {
  // ...
});

[pangratz]

I think it is ok to use the patched QUnit module version for now, as this is also the way it is done in ember-dev. Once this lands in ember-data, I will backport stuff to ember-dev so it is usable for other addons as well...

[bmac]

Thanks @pangratz