[BUGFIX beta] Add ducktyping of AdapterError

[danmcclain]

There are instanceof checks for AdapterError; this removes it in favor of checking for a property on the error. isAdapterError appears on all errors that use AdapterError as the base.

This PR is looking to avoid the need to import private errors in fastboot to keep the same code flow in the ajax method used in node land, related PR: ember-fastboot/ember-cli-fastboot#95

[danmcclain]

Tests were failing locally even when reverting so I figured I'd try pushing anyway. Will dig back in tomorrow morning. Would like feedback on direction as well

/cc @rwjblue

[rwjblue]

Using flags seems better than using instance of to me...

[danmcclain]

Slightly confusing, there are 2 different definitions for InvalidError, changed this so it only handles AdapterError which is the one that fastboot is checking for ultimately

[bmac]

there are 2 different definitions for InvalidError

@tchak is this an oversite or do we need 2 definitions for InvalidError?

[bmac]

@danmcclain Is this something that should be considered a [BUGFIX beta] so it can be included in the 2.4 release?

[danmcclain]

@bmac Here are the 2 different definitions:
Adapter InvalidError:

data/addon/-private/adapters/errors.js

Lines 85 to 90 in 209326f

	export function InvalidError(errors) {
	assert('`InvalidError` expects json-api formatted errors array.', Ember.isArray(errors || []));
	AdapterError.call(this, errors, 'The adapter rejected the commit because it was invalid');
	}
	InvalidError.prototype = Object.create(AdapterError.prototype);

Model InvalidError:
https://github.com/emberjs/data/blob/209326f22324d8e29eee0207908d02725f7cb83e/addon/-private/system/model/errors/invalid.js

Also, I can label as such, I didn't give it a label, as I was unsure what you would want it to be

[danmcclain]

@bmac I think [BUGFIX beta] would apply. Labeling as such now

[tchak]

I am not a big fan of this. I started some work to make it easy to inherit from AdapterError which seems to me like a better practice. But I do understand that it makes life easier in some cases, so I guess it's 👍

The two definitions of InvalidError is definitely a bug/oversight.

[rwjblue]

@tchak Using instanceof has generally been problematic for us in Ember, so we have been switching to using flags like this.

[rwjblue]

Should likely be response && response.isAdapterError in case response is undefined / null.

[bmac]

@danmcclain @rwjblue added one final comment. Once that is fixed this pr should be ready to be merged.

[danmcclain]

@bmac will update shortly 👍🏼

[danmcclain]

@bmac updated per @rwjblue's comment

[bmac]

Thanks @danmcclain

[tchak]

@rwjblue ok. I see quite well why instanceof can be problematic. It just makes me very sad... But such is life :)