[BUGFIX beta] Export more public API's via modules #4125
Conversation
|
We started with these alias type of modules for the early 2.3.0-betas, but ended up having issues and changing things around to move the actual module to the new public location (instead of shim modules). IMHO, we should be consistent in our public modules. So either they existing ones should be made into shims, or these should be moving the underlying modules and avoid shims... |
|
I am all for avoiding shims. |
|
Are |
|
I don't think this needs to be a |
You are right, they might not be needed as public API. I removed the public API modules for the transforms. |
| @@ -0,0 +1,3 @@ | |||
| import Serializer from "ember-data/-private/system/serializer"; | |||
|
|
|||
| export default Serializer; | |||
There was a problem hiding this comment.
@pangratz could you move the Serializer and EmbeddedRecordsMixin out of the -private folder and into their new public locations.
|
I moved the files from the private location to the public ones. Also, the embedded records mixin is now located at |
|
|
||
| test("ember-data/serializers/rest", function(assert) { | ||
| assert.ok(RESTSerializer); | ||
| }); |
|
👍 looks good to me. Just needs a rebase. |
This change allows to import more public API's via modules: - import Serializer from "ember-data/serializer" - import EmbeddedRecords from "ember-data/serializers/embedded-records-mixin"
|
@bmac done |
[BUGFIX beta] Export more public API's via modules
This change allows to import more public API's via modules:
import Serializer from "ember-data/serializer"import EmbeddedRecords from "ember-data/serializers/embedded-records-mixin"Should this be
[BUGFIX release]?cc @fivetanley @bmac