-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create RELEASE.md #4173
Create RELEASE.md #4173
Conversation
======= | ||
|
||
Although not very tricky, the Ember Data release process does have a | ||
lot of manual steps. The following steps navigate a through |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems slightly oddly worded "navigate a through" (maybe "us through"?)...
In the website update section, we need to update the |
* generate changelog (`PRIOR_VERSION=v2.0.0 HEAD=release ./bin/changelog`) | ||
* prepend changelog output to `CHANGELOG.md` | ||
* edit changelog output to be as user-friendly as possible (drop [INTERNAL] changes, non-code changes, etc.) | ||
* Bump version in package.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know how obvious, but should there be a git commit --all --message "Release Ember Data X.Y.Z"
after the bump?
|
* Commits since last release: `git log --oneline release..beta | wc -l`. | ||
* Contributors since last release: `git shortlog -s -n release...beta | wc -l` | ||
* Submit a Pull request to the https://github.com/ember-cli/ember-cli to update the version of Ember Data | ||
* (per request by @rwjblue and is also a great idea to make upgrading/new apps easier) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe there should be an entry to update the version in ember-twiddle as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd kinda like to avoid adding yet one more step to our release process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good 👍
In the spirit of https://github.com/ember-cli/ember-cli/blob/master/RELEASE.md this copies the steps I've been using for doing a release from #2789 to a new
RELEASE.md
file to make it easier to allow other contributors do perform a release.