DS.Store type presence checks

[courajs]

Fixes #4170.
Are you alright with generated tests like this?
I wasn't quite sure where to put these. serializerFor, createRecord, and a few others have their own test files, but many of these didn't really seem to have a home. It also seems a small shame to split these tests up when they're almost exactly the same.

[wecc]

Thanks @courajs!

We have a couple of other tests where we loop inside of one test(...) instead of generating multiple tests. This gives us the ability to set expected asserts (something like assert.expect(MODEL_NAME_METHODS .length) in this case).

See here for an example.

[courajs]

Alrighty, I've updated to use only one test with many asserts

[bmac]

Ember Data uses modelName for the type argument in most of these functions. I also know that type has also been used to refer to the same information. I think we should pick one term and be consistent. Right now I have a preference for modelName but I could easily be convinced to use type instead.

[pangratz]

It looks like it's not very consistent at the moment (see this and this), but I am in favor of modelName too, since it looks like the parameter for most method documentations is named modelName as well.

[courajs]

I've changed "type" to "model name" in the assertion messages

[pangratz]

Since #4223 the tests are also run in the production environment, where the assertions are stripped. That's why this test is failing.

You need to use testInDebug here instead of test:

import testInDebug from 'dummy/tests/helpers/test-in-debug';

Sorry you fell over this. This is my fault, I need to update CONTRIBUTING.md ASAP.

[pangratz]

Can you squash into 1 commit and prefix with [BUGFIX beta]?

I think then this is good to go 🚀

[bmac]

Thanks @courajs.