Run tests in production #4223
Merged
Run tests in production #4223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pangratz do you mind rebasing this pr? |
| import RecordReference from './references/record'; | ||
| import BelongsToReference from './references/belongs-to'; | ||
| import HasManyReference from './references/has-many'; | ||
| import RecordReference from 'ember-data/-private/system/references/record'; |
There was a problem hiding this comment.
relative should work correctly, if it does not that is a bug in the build we need to fix.
There was a problem hiding this comment.
Sure thing. Let's wait until that is resolved, then I will rebase and remove this commit.
There was a problem hiding this comment.
It looks like this has been resolved with #4215 🎉
This test contains assertions for correctly rejected records in coalesced requests AND an assertion that a warning is logged. This commit splits the test into two: the first tests the correct behavior for rejected records and the second tests that the warning for missing records is logged. The splitting is necessary since in an upcoming commit the tests are run in production too: since in that environment tests which check for assertions are stripped, currently we would lose this test. That's why this test is split beforehand so the behavior is tested in production build as well.
This adds a `testInDebug` helper, which skips tests when run in production. This helper either runs the tests normally via QUnit.test if we are not in a production environment. If the test is executed within production however, QUnit.skip is used instead so the test is skipped. This allows us to skip tests which don't make sense in the production environment: this are tests which check for warnings and assertions thrown within code. Since those assertions/warnings are stripped from production code, it doesn't make sense to run those tests in that environment.
|
Thanks @pangratz |
This was referenced Mar 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new test helper
testInDebugwhich executes a test viaQUnit.testif we are not in theproductionenvironment. If the tests are executed inproductionenvironment though, then the test is skipped viaQUnit.skip.The tests are now also run on TravisCI via
ember test --environment=production.This addresses #4203.
TODO