blueprints: Use project.dependencies() to determine test framework #4184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
LGTM 👍 |
|
Thanks @Turbo87. Can you squash the changes into 1 commit? |
…t framework This has the advantage of not requiring the package to actually be installed and will enable us to test the mocha blueprints properly. blueprints: Prioritize "ember-cli-qunit" over "ember-cli-mocha"
|
@pangratz done |
pangratz
added a commit
that referenced
this pull request
Feb 24, 2016
blueprints: Use project.dependencies() to determine test framework
|
Herzlichen Dank! |
|
Bitte schön 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is changing the test framework detector of the blueprints to use
project.dependencies()instead ofproject.addonPackages. This has the advantage of not requiring the test framework to actually be installed and will enable us to test the mocha blueprints properly.see ember-cli/ember-cli-blueprint-test-helpers#28 for further information on this
/cc @rwjblue @trabus